automod context plumbing #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rule's name should describe what it does, not presumptively describe the valence of what it hopes that it's detecting.
Context objects are now available in all rules. This is mostly not yet used, but prepares for future needs. It does also remove one TODO -- in a rule that uses a directory lookup. I took the liberty of adding type assertion "variables" to the header of each rule file, while at it.
|
What do you think about plumbing the |
|
We can discard this. Even as I was making these edits, I was coming around to thinking... yeah, the sheer args list length feels high and noisy. I agree making some kind of "business context" one-stop-shop object feels like it will make a lot of sense. We might as well start that in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumb context through rules.
This is mostly not yet used, but prepares for future needs. It does also remove one TODO -- there was one existing rule that uses a directory lookup, and was doing so without a fully connected context.
I took the liberty of adding type assertion "variables" to the header of each rule file, while at it.
(Currently also includes a few commits from another branch, but will rebase as soon as that's merged.)