dont include did doc in create session for now #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm, I had just done a patch to lexgen which made this field, and a couple other non-record my main concern is with having to manually comment out these fields after every run of lexgen, that is a footgun and somebody will forget or not know they need to do that. |
|
Please always remove it from other places too. getSession and refreshSession are still broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The did doc is defined as an
anytype in the lexicon right now, which in all other cases implies a record (with a $type field). For now, lets just ignore this in the go code (its not necessary for anything) until we figure out a better way forward.