Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay: return explicit empty array, not nil, for sync.listRepos #473

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

bnewbold
Copy link
Collaborator

This is a work-around for the specific situation in: bluesky-social/atproto#1949

We may need to have lexgen stubs ensure that any required array types in Output types are set to an explicit empty array, instead of nil? I haven't dug in to the details of JSON marshaling and CBOR marshaling to understand the scope of this issue yet, but the root of the issue is that the typescript code is being more strict about "empty" types than golang is. The typescript strictness seems both correct and reasonable to me, FWIW.

Copy link
Collaborator

@ericvolp12 ericvolp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnewbold bnewbold merged commit 5a20c86 into main Dec 15, 2023
7 checks passed
@bnewbold bnewbold deleted the bnewbold/relay-sync-repos branch December 15, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants