relay: return explicit empty array, not nil, for sync.listRepos #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-around for the specific situation in: bluesky-social/atproto#1949
We may need to have lexgen stubs ensure that any required array types in Output types are set to an explicit empty array, instead of nil? I haven't dug in to the details of JSON marshaling and CBOR marshaling to understand the scope of this issue yet, but the root of the issue is that the typescript code is being more strict about "empty" types than golang is. The typescript strictness seems both correct and reasonable to me, FWIW.