Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset backoff after successful connection in fedmgr #471

Merged
merged 2 commits into from
Dec 12, 2023
Merged

reset backoff after successful connection in fedmgr #471

merged 2 commits into from
Dec 12, 2023

Conversation

whyrusleeping
Copy link
Collaborator

No description provided.

@whyrusleeping
Copy link
Collaborator Author

the problem this has is that if the connection works but the stream is bad, we will still loop here endlessly.
I wonder if I should check that we've actually processed additional events (by checking that the cursor has increased) before resetting the backoff counter

@whyrusleeping whyrusleeping merged commit 51ad672 into main Dec 12, 2023
7 checks passed
@whyrusleeping whyrusleeping deleted the fix/backoff-reset branch December 12, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@whyrusleeping