update lexicons to latest #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
approved these changes
Dec 11, 2023
lex/gen.go
Outdated
Comment on lines
1197
to
1202
| /* | ||
| if len(ts.Properties) == 0 { | ||
| pf("type %s interface{}\n", name) | ||
| return nil | ||
| } | ||
| */ |
There was a problem hiding this comment.
was this intentional? if we'll come back to this later, a comment describing why it is commented out for now
There was a problem hiding this comment.
yeah, this was actually not used for a long while, and now that it is again, we actually want empty structs defined (the threadgate rules are all empty structs with a type field)
|
also, while you are touching lexgen, might want to merge this small PR which reduces the number of manual tweaks required: #448 |
whyrusleeping
force-pushed
the
feat/lexicon-update-dec8
branch
from
8208bd2 to
5933059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.