only traverse cbor blocks when running mst diff #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spaced the fact that we include proper dag-cbor cid links to images which are not actually included in the car slices. In the case where someone drops a reference to an image (deletes an image post, or updates their profile picture) then we would hit this 'ipld not found' error on the image cid (since we never got it in the first place).
Here, we skip any CID that isnt CBOR, This is a reasonable assumption to make for now, unless we start dangling random cbor graphs off of the MST, at which point ill probably need to get more clever (I'd really rather not).