drop consumers if their out buffer fills up #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hrm.... this isnt quite right, it doesnt close out the connections and will result in a hanging subscriber |
|
This should work now |
|
Actually we should probably emit a |
ericvolp12
reviewed
Nov 6, 2023
ericvolp12
reviewed
Nov 6, 2023
ericvolp12
reviewed
Nov 9, 2023
events/events.go
Outdated
| go func(torem *Subscriber) { | ||
| em.rmSubscriber(torem) | ||
| select { | ||
| case s.outgoing <- &XRPCStreamEvent{ |
There was a problem hiding this comment.
should this be torem.outgoing?
There was a problem hiding this comment.
good catch reviewer.
ericvolp12
reviewed
Nov 9, 2023
events/events.go
Outdated
| }, | ||
| }: | ||
| case <-time.After(time.Second * 5): | ||
| log.Warnw("failed to send error frame to backed up consumer", "ident", s.ident) |
There was a problem hiding this comment.
this should be torem.ident
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now if these buffers fill up we just start dropping events, and then when the buffers drain we just resume sending events. this seems quite wrong.