Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve timeouts on event streams a bit #404

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

whyrusleeping
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ericvolp12 ericvolp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run this in test as well with a slow consumer to see how it behaves, we've got a good number of consumers consuming slower than realtime right now. Might be good to kick them off.

@whyrusleeping
Copy link
Collaborator Author

so this shouldnt actually affect consumers, but now im realizing that we probably want to put it in the Pong handler or something, because if we don't receive any events from the pds for a minute, this will kill the connection (even if the ping-pongs still happen)

Copy link
Collaborator

@ericvolp12 ericvolp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely want to see this one tested with a slow consumer before prod rollout but hopefully should prevent stuck sockets.

@whyrusleeping whyrusleeping force-pushed the fix/evt-stream-timeouts branch from 599e374 to 90d357c Compare November 20, 2023 17:54
@whyrusleeping whyrusleeping merged commit 5402084 into main Nov 20, 2023
6 checks passed
@whyrusleeping whyrusleeping deleted the fix/evt-stream-timeouts branch November 20, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants