Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance tweaks to palomar profile typeahead #391

Merged
merged 8 commits into from
Oct 11, 2023
Merged

performance tweaks to palomar profile typeahead #391

merged 8 commits into from
Oct 11, 2023

Conversation

bnewbold
Copy link
Collaborator

No description provided.

@bnewbold bnewbold requested a review from ericvolp12 October 11, 2023 02:46
ericvolp12
ericvolp12 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@ericvolp12 ericvolp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, gonna roll it out to staging and bench it tonight

@ericvolp12
Copy link
Collaborator

ericvolp12 commented Oct 11, 2023 •
edited
Loading

image
image

Load testing looks good, I'm satisfied this most likely won't require a rollback due to performance (at least for latency).

@bnewbold bnewbold merged commit 783d780 into main Oct 11, 2023
@bnewbold bnewbold deleted the bnewbold/palomar-fixes branch October 11, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvolp12 ericvolp12 ericvolp12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnewbold @ericvolp12