syntax: Datetime, URI, CID, TID #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvolp12
reviewed
Oct 4, 2023
atproto/syntax/tid.go
Outdated
| } | ||
|
|
||
| // Constructs a new TID from a UNIX timestamp (in milliseconds) and clock ID value. | ||
| func NewTID(unixMilis int64, clockId uint) TID { |
There was a problem hiding this comment.
I wonder if this should take a time.Time and extract the milliseconds for us. Thinking about the calling conventions here and Go doesn't really deal with millisecond time often.
Also is this Microseconds or milliseconds? The usage below implies this is Microseconds?
There was a problem hiding this comment.
ah, good catch on the millis/micros, I fixed the behavior but didn't remember to update the variable names (or a test call).
I added NewTIDFromTime. I'd be open to renaming and have NewTID take a time and rename the existing to NewTIDFromUnixMicros (eg). I think it is fine either way.
ericvolp12
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of these parse helpers.
Datetimeis the main thing here, with a bunch of test cases.TID is also helpful, and a bunch of little interop issues came up when implementing this.
The CID and URI ones are a bit weird. URIs aren't very well spec'd in a general/abstract sense, and for CIDs we already have
go-cidwhich is what would normally be used. But I think it is good to have string-only validation that ensures exact pass-through, and can be used as a type signature.Questions for review: