for now, add duplicate stale refs to the keep set #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/dupe-compact-workaround
branch
from
7a2f105 to
c764642
Compare
|
something wonky with this, ends up with missing blocks sometimes.. need to investigate |
whyrusleeping
force-pushed
the
feat/dupe-compact-workaround
branch
from
9828ac8 to
fedc32e
Compare
whyrusleeping
force-pushed
the
feat/dupe-compact-workaround
branch
from
fedc32e to
9cd7059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a deleted block matches multiple blockRefs in a given repo, we can't safely assume its no longer referenced. The 'correct' way to move forward is to do a full repo traversal to enumerate the 'correct' set of blocks referenced in the MST, but that requires more thought and is actually something that needs to be done at the repo manager level (and involves extra locking and other shenanigans that i dont want to implement just yet).
So for now, we add duplicate blocks to the keep set and just assume they are still being referenced somewhere.