do shard deletions in batches #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/compaction-batch-delete
branch
from
34932e0 to
9499008
Compare
ericvolp12
approved these changes
Sep 19, 2023
Comment on lines
+988
to
+997
| for _, sh := range shs { | ||
| if err := cs.deleteShardFile(ctx, sh); err != nil { | ||
| if !os.IsNotExist(err) { | ||
| return err | ||
| } | ||
| outErr = err | ||
| } | ||
| } | ||
|
|
||
| return outErr |
There was a problem hiding this comment.
Is this bit just to return at least one IsNotExist if any of the shards end up already having been deleted but we don't wanna let that stop us from deleting the others, however if there's some other error we're interested in stopping immediately and returning?
There was a problem hiding this comment.
exactly, yeah. i want to at least try to delete everything, if we fail because the file is already gone, we continue (but still let our caller know it happened). if we fail for some other error i think it makes sense to bail out immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compaction on rapidly changing repos is slow and 99% of the time is spent in deleteShard. This speeds it up a little bit, from there we can look at what else gets in the way.