Add backfilling to search backed by GORM #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
reviewed
Aug 31, 2023
|
I haven't reviewed in depth, but i'm pretty darn excited about having a generic backfill mechanism like this! Great work. |
| return | ||
| } | ||
|
|
||
| req.Header.Set("Accept", "application/vnd.ipld.car") |
There was a problem hiding this comment.
all this feels like it wants to be abstracted out a little. i assume you have a non-lexicon 'fetch repo' endpoint youre hitting?
There was a problem hiding this comment.
This is the lexicon GetCheckout endpoint, which we could do with an XRPC client and such but the body is just a raw CAR payload and we don't gain anything by using the lexicon and XRPC boilerplate here really... I don't even need this header to be honest.
whyrusleeping
approved these changes
Sep 5, 2023
ericvolp12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search will need to backfill regularly when rebuilding indexes.
I've adopted a backfill pattern I created a few weeks ago into
indigoand updated Search's firehose consuming to adopt the backfilling pattern.