Separate Subscription and Algorithm Functionality #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone gona review this |
wisdoms6969
approved these changes
Dec 22, 2023
wisdoms6969
approved these changes
Dec 22, 2023
wisdoms6969
approved these changes
Dec 22, 2023
wisdoms6969
approved these changes
Dec 22, 2023
|
@dholms Can I get a review on this PR or someone else who is a maintainer? |
wisdoms6969
approved these changes
Dec 22, 2023
haileyok
force-pushed
the
main
branch
2 times, most recently
from
d36deef to
fadd462
Compare
|
@ebwinters Would subscription be a good place to filter by language? |
|
yes |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR came after confusion while trying to understand the feed generation process after reading the README. I was looking in the algorithm thinking I missed some logic regarding
ALFbut was surprised to find it in the subscriptionCurrently the subscription performs the logic that should reside in the algorithm. Additionally, the current algorithm has nothing to do with text comparison, it just takes latest posts. It could just be called
latest-posts.Indexing posts is independent of generating content, and since
whats-alfuses the text of the post, not other metadata, we should store text for this example