Fix initial cursor #54
Open
+2,938
−622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support .env file * Fix default sub endpoint
* Setup migrations, misc tidy/fixes * Simplify migration provider
readme tweaks
* update README with instructions for the default URL * Update README.md --------- Co-authored-by: Daniel Holmgren <[email protected]>
* describeFeedGenerator route + multiple feeds * tweak readme
* describeFeedGenerator route + multiple feeds * tweak readme * improve env
* describeFeedGenerator route + multiple feeds * tweak readme * improve env * publish script * create -> put * readme * handle blob encoding * add check that feeds are available
So readers won't have to google Bluesky PDS to try to figure out what it means
(cherry picked from commit 1b2f04a)
* improve docs & helpers around publisher dids * add docs to env
Cosmetic: remove trailing space
m1kola
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
I did exactly the same thing in my feed.
Alternative might be (not super familiar with this stack) - leaving the update query alone, but adding a data migration which adds a row into the sub_state table. But that would require a data migration for each web socket endpoint (service col).
haileyok
force-pushed
the
main
branch
2 times, most recently
from
d36deef to
fadd462
Compare
|
@AvivRubys thanks for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running for the first time, we only update the cursor but don't create the initial row, so it doesn't update anything.
Solution
Changed the update to an upsert. Ran locally and verified
sub_statewas empty before, and after the change has a single row.