-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve subtitle telemetry display and configurations #946
Improve subtitle telemetry display and configurations #946
Conversation
ArturoManzoli
commented
May 10, 2024
•
edited by ES-Alexander
Loading
edited by ES-Alexander
- Based on @ES-Alexander's idea and wireframes;
- Sensors logging: improve control on logging and subtitle overlays #621
- User can configure details of the on-screen subtitle data telemetry display;
- Telemetry frequency configuration on separate tab;
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far - super keen for this to be made available once it's cleaned up! :-)
e3bfdc9
to
6205255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems reasonable, although I haven't looked super in depth.
Tried it out and it mostly works well (nice!), although there are a few weird UI things:
Screen.Recording.2024-05-14.at.11.01.55.PM.mov
- dragging a variable from the options shows it left-aligned in the grid positions
- the expected behaviour works correctly when dragging it from a grid position, where it then shows in the actual location it would go in any other grid position it's dragged over
- it seems weird that it's possible to drag and leave a variable in a different input section than the one it came from, especially since the variables within each input section get automatically sorted, which makes them feel like they have a "correct" place
- it would be nice if the styling options were previewed on the variable names, so it's clearer what each style change looks like
- ideally the styling options would be able to apply to individual variables rather than the entire overlay
- e.g. you could click a variable to select it, which would open the styling options for that variable
- it would be nice to allow typing in the "font size" dropdown, or at least provide some more sizes above 30
- window sizing can make the "shadow size" dropdown unreadable
- it would be nice if the input variable sections had a maximum height, after which they become scrollable, or at least just make the input variables column scrollable instead of the whole page
- since the current approach just extends the page, you can end up in a situation where the whole grid is off screen and you can't drag your variables into it
- the mission name only gets recorded if it has been manually changed - the automatic names don't appear in the subtitles
I can't seem to delete the videos from Cockpit once I've downloaded them- that's apparently just a bug in Cockpit, since I was able to replicate the issue in the latest beta as well 🤷♂️
They're not critical, but would be nice to fix if it's not too challenging to do so :-)
…rants positioning Signed-off-by: Arturo Manzoli <[email protected]>
6205255
to
bfd14b4
Compare
Latest updates from @ES-Alexander changes request: 3 and 4- This grid/variable individual styling and preview is planned to be implemented when porting this screen to the next UI; 7- There is an auto-scroll feature when you drag a chip to the top of the view area. Too many scrollbars usually degrades the UI harmony and inserting them in this case also did. Anyway, your suggestion was added to the next UI port. 8- The standard text for non named missions is 'cockpit', that goes onto the filename when downloading a video, for example. Now the 'Mission name' tag will show 'Cockpit' instead of simply not showing anything. |
bfd14b4
to
7bebdb1
Compare
3ced665
to
3a6924f
Compare
Hey @ES-Alexander, thanks for taking the time to review this PR and for providing such detailed and valuable feedback. 👍 As a MacOS user, things might be presented a little differently for you (and this is very useful), such as the hotspot for auto-scrolling being outside the view area and the number inside the selector for the shadow size being cut off. About 2- Is nice to reset the variable positions between UI updates. Their references may change and odd behavior may occur. Updates: |
No worries - glad I can help find and resolve some issues before they end up in a release :-) 1, 6 - Nice 👍 Screen.Recording.2024-05-16.at.11.10.43.PM.mov2 is definitely some kind of bug, 7 might just be an OS difference or something (I don't think that one's a big deal, just not quite as nice as it could be - I think it's ok to merge this once 2 is fixed if 7 is hard to track down, although it might just be an element layering thing in terms of where pointer events are registered - not sure 🤷♂️ ). |
For 2, I'm pretty sure the issue is caused by line 307 - that likely needs a filter for "unless it's in the mission variables" :-) |
…tioning configurations Signed-off-by: Arturo Manzoli <[email protected]>
3a6924f
to
f12c295
Compare
Nice catch. The filtering was being triggered too late on line 317. Moved to line 307. |
About 7, I think I saw it working (but a little laggy) on the first seconds of the video you posted. If you change the line: Check the regular behavior on Chrome: |
2 is fixed 👍
Nah, that's when the chip goes into one of the grid cells, which then scrolls the page to bring that full cell into view.
I'm on Chrome, so not a Safari issue.
I tried this and it does work but it's super jarring, so I wouldn't say it's a better solution.
The behaviour in your video looks as I'd expect/hope mine to work :-) I played around a little and found out that if I flip the threshold check on line 389 I get the desired behaviour, so it seems the Y direction in my Chrome is upwards (graph style), whereas I suppose in yours it's downwards (image/matrix style)? I tried a different browser and the original threshold comparison worked as expected, so I think we can just assume it's a bug in my Chrome version or something and leave it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for sorting out those issues! :-)