Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit-menu: Disable cog icon for widgets that are not configurable #1577

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Jan 16, 2025

The end of an era...

image

The cursor also changes to the not-allowed type when hovering a not-configurable one.

Fix #541

@rafaellehmkuhl rafaellehmkuhl force-pushed the disable-cog-for-widgets-without-congi-menu branch from 4cd4077 to addd0b9 Compare January 16, 2025 20:25
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 17, 2025
Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Fantastic to see this one getting addressed :-D

I've tested and it works well for regular and mini-widgets.

It doesn't seem to be working for Input Widgets, but they currently get configured differently to other widgets anyway - the relevant fix for that might already be included in #1559.

@rafaellehmkuhl
Copy link
Member Author

Woohoo! Fantastic to see this one getting addressed :-D

I've tested and it works well for regular and mini-widgets.

It doesn't seem to be working for Input Widgets, but they currently get configured differently to other widgets anyway - the relevant fix for that might already be included in #1559.

I didn't changed it for the input widgets exactly because of this open PR, so we don't create much conflicts. @ArturoManzoli you take a look on it to replicate it there?

@rafaellehmkuhl rafaellehmkuhl merged commit 662d7f4 into bluerobotics:master Jan 17, 2025
11 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the disable-cog-for-widgets-without-congi-menu branch January 17, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-needed Change needs to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini-widgets without configuration options should not have an edit button
2 participants