Add widget api #1503
Add widget api #1503
Conversation
Williangalvani
force-pushed
the
widget_api
branch
9 times, most recently
from
bc86de2 to
07b912b
Compare
Williangalvani
force-pushed
the
widget_api
branch
11 times, most recently
from
e1d4e3c to
cb52d94
Compare
.github/workflows/publish-lib.yml
Outdated
| { | ||
| echo '{ | ||
| "name": "@bluerobotics/cockpit-api", | ||
| "version": "'${{ github.ref_name }}'", |
There was a problem hiding this comment.
I think we should not use the cockpit version here. thoughts?
There was a problem hiding this comment.
We shouldn't. Cockpit has new releases every week, while the API will probably be updated every few months.
| /** | ||
| * Current version of the Cockpit Widget API | ||
| */ | ||
| export const COCKPIT_WIDGET_API_VERSION = '0.0.0' |
There was a problem hiding this comment.
This should be injected in build time, right?
There was a problem hiding this comment.
yes. where should the "source of truth" live, though?
There was a problem hiding this comment.
Difficult.
If it was in its own repo, we could track the git release, but in this case we maybe have to hardcode it in the packages.json?
There was a problem hiding this comment.
idk. we need it in 3 places: packages.json, publish-lib.yml, and api.ts 🤔
is it easier to move from code to packages.json or from packages.json to code?
There was a problem hiding this comment.
I'm thinking of leaving the source of truth on publish.yaml
then we can make it an environment variable for building, and use sed to inject it into packages.json.
I don't really like the idea, but I can't think of anything better. thoughts?
There was a problem hiding this comment.
Sounds valid. Can't think of something better either.
Williangalvani
force-pushed
the
widget_api
branch
from
cb52d94 to
13312b8
Compare
Williangalvani
force-pushed
the
widget_api
branch
from
13312b8 to
4d6333e
Compare
No description provided.