do not dup secrets

bluedynamics · Jun 28, 2024 · f2115ed · f2115ed
1 parent e4124bf
commit f2115ed
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 84 deletions.
diff --git a/API.md b/API.md
diff --git a/src/index.ts b/src/index.ts
@@ -1 +1 @@
-export { Plone, PloneOptions } from './plone';
+export { Plone, PloneOptions, PloneBaseOptions } from './plone';
diff --git a/src/plone.ts b/src/plone.ts
@@ -6,17 +6,16 @@ import { PloneService } from './service';
 
 export interface PloneBaseOptions {
   readonly image?: string;
-  readonly imagePullSecrets?: string[];
   readonly imagePullPolicy?: string;
   readonly replicas?: number;
   readonly maxUnavailable?: number | string;
   readonly minAvailable?: number | string;
   readonly environment?: kplus.Env;
-
 }
 export interface PloneOptions {
   readonly backend?: PloneBaseOptions;
   readonly frontend?: PloneBaseOptions;
+  readonly imagePullSecrets?: string[];
 }
 
 export class Plone extends Construct {
@@ -33,7 +32,7 @@ export class Plone extends Construct {
     const backendDeployment = new PloneDeployment(this, 'backend', {
       image: {
         image: backend.image ?? 'plone/plone-backend:latest',
-        imagePullSecrets: backend.imagePullSecrets ?? [],
+        imagePullSecrets: options.imagePullSecrets ?? [],
         imagePullPolicy: backend.imagePullPolicy ?? 'IfNotPresent',
       },
       replicas: backend.replicas,
@@ -61,7 +60,7 @@ export class Plone extends Construct {
     const frontendDeployment = new PloneDeployment(this, 'frontend', {
       image: {
         image: frontend.image ?? 'plone/plone-frontend:latest',
-        imagePullSecrets: frontend.imagePullSecrets ?? [],
+        imagePullSecrets: options.imagePullSecrets ?? [],
         imagePullPolicy: frontend.imagePullPolicy ?? 'IfNotPresent',
       },
       replicas: frontend.replicas,
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export { Plone, PloneOptions } from './plone';
		export { Plone, PloneOptions, PloneBaseOptions } from './plone';