Add unittests for input validations #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. |
gerritdm
force-pushed
the
20190805_23_input_validation_unittests_gdm
branch
from
b1b6585 to
22db762
Compare
- fuels - auxiliary - operations/init - project/init - must_run - dispatchable_no_commit - always_on (uses validations from auxiliary) - dispatchable_capacity_commit (uses validations from auxiliary)
gerritdm
force-pushed
the
20190805_23_input_validation_unittests_gdm
branch
from
1a3468d to
cf1c98a
Compare
|
Added the unittests to all validations. This required quite a bit of refactoring. |
gerritdm
added
type: enhancement
anamileva
reviewed
Aug 14, 2019
There was a problem hiding this comment.
This looks good. The operations/test_init.py test throws this warning: gridpath/project/operations/__init__.py:585: RuntimeWarning: divide by zero encountered in true_divide slopes = incr_fuel_burn / incr_loads. Could you look into fixing that and then we can merge?
|
Fixed the error. Unittests are running OK for me now. |
anamileva
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unittests to all current input validations. This required quite a bit of refactoring but the validations itself haven't changed.
Closes #86