-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error-handling for missing or incorrectly specified script arguments #111
Comments
This definitely applies to the viz plot scripts. Right now the error will propagate to the SQL command and you get an unhelpful sqlite error. We should catch this earlier and give a clear warning to the user that tells what argument is missing where. |
Sort of related, but I also wonder whether we should replace |
This discussion has some good suggestions on how to do this: |
I considered that, but it's a bit of an issue with run_start_to_end, as the scripts it calls don't share the arguments. We could get around that by passing individual arguments -- not the whole object -- to the series of scripts from run_start_to_end. Full circle back to our discussion from yesterday. |
I've been running into some of this again with the plots. A few thoughts:
|
One easy improvement would be to update A simple |
This way the --help message will be more clear and won't list the required arguments under optional arguments, which is the default for argument flags (--arg or -a), whether they are required or not. Note: to show the required arguments before the optional arguments we rely on a hacky fixed that accesses and changes a private attributes of the parser object (it reverses the list order). This addresses some of the issues raised in #111.
Consolidated in #6. When we address this, we can re-open it and have the PR that address it close it. |
Add some error-handling for when the user does not specify all required script arguments, as the traceback can be rather unhelpful.
The text was updated successfully, but these errors were encountered: