Input data checks and validation

[anamileva]

• Mismatching operational types (e.g. binary commit and new build)
• New build projects have to be self consistent with new build vintage costs (gen / storage / tx)
• Validate that at least one project is contributing to each reserve/policy/reliability zone. Currently, we can have reserve/policy/reliability zone with no projects that can contribute toward meeting their target, see Validate that at least one project is contributing to each reserve/policy/reliability zone #347.
• Disallow combination of certain availability types and capacity types. Since capacity is multiplied by derate, we can't allow combinations of availability types and capacity types where both are decision variables. That means we have to disallow endogenous availability derates and new build or retirement capacity types. See Disallow combination of certain availability types and capacity types #249. Edit: closing since non-linear problems are actually okay, just harder to solve.
• Provide useful error messages when the wrong key words are given to e.g run_scenario.py; right now the original wrong keyword error is obscured and the model will fail at a later stage; see Error-handling for missing or incorrectly specified script arguments #111.
• Validate missing var profiles (right now just a warning, see discussion in Refactor loading in variable profiles #543).
• Validate that hydro avg is between min and max.
• Validate that the horizons specified in structure.csv matched those in horizon_params.csv (or the equivalent database tables).
• add basic general validation to capacity types similar to operational types
• Validate that fully deliverable energy iimited projects are assigned a min duration for full cap credit (removed in Consolidate database utilities #605)
• Validate that energy only allowed projects are assigned a deliverability group and that other types don’t have one (removed in Consolidate database utilities #605)
• Check that all 'fully_deliverable_energy_limited' projects are assigned a min_duration_for_full_capacity_credit_hours
• Check if all ''energy_only_allowed' projects are assigned a 'deliverability group' and that other types are not assigned one
• Mismatched temporal setup and project balancing types (e.g. Missing definition of 'year' horizon not caught during validation #819)

[gerritdm]

Updated the comment to add a couple sub-tasks. I imagine this list will grow as we come up with more input validation checks. The foreign keys in the database might be a good start to find inputs that have to be self-consistent (but in that case, wouldn't the database already insure they are?)

[anamileva]

@gerritdm, could you take a look and update this issue in case any of the remaining items have actually been fixed?

[gerritdm]

Just reviewed this and crossed out one more.