Feat/ldg 508 nano app implement getpublickey method #9
Conversation
- Add Ed25519 public key derivation functionality - Update public key context structure to handle 32-byte keys - Add UI flows for public key confirmation - Add tests for get_public_key command - Add initial support for signed public keys (WIP) Note: Signed public key functionality is implemented but not working correctly yet. Tests show mismatch between expected and actual signatures. BREAKING CHANGE: Public key format changed from 65 to 32 bytes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
- Update helper_send_response_pubkey to sign raw public key instead of hash - Remove unused m_hash field from pubkey context structure - Fix signature verification by using correct input data This fixes the issue where signed public keys were not verifying correctly due to signing the wrong input data.
Add a new screen to display the BIP32 derivation path when showing public keys in the BAGL UI. This improves user verification by showing the full derivation path before the public key. - Add MAX_SERIALIZED_BIP32_PATH_LENGTH constant - Update derivation_path_type to handle governance paths - Add new UI step for BIP32 path display - Format and show derivation path in pubkey display flow
- Replace simple address review with detailed NBGL review layout - Add BIP32 path display alongside public key - Update test snapshots for new UI layout The change improves the user experience by showing both the BIP32 path and public key in a clear, structured format using the NBGL review light interface.
* refactor(tests): update pubkey command tests to use new navigation helper * feat(tests): add navigate_until_text_and_compare utility function * feat(tests): add instructions_builder helper for screen navigation The changes improve test maintainability by abstracting common navigation patterns into reusable utilities that handle device-specific behavior (Stax/Flex vs others) consistently.
* feat: add new function to handle signed public key response unpacking * fix: correct return type annotation for get_public_key_response * style: add consistent spacing between functions * chore: enable formatOnSave in VSCode settings Adds utility function to unpack signed public key responses and fixes type hints for existing public key response unpacker. Improves code formatting consistency across the test suite.
* chore: comment out boilerplate fuzzing test parser * chore: comment out boilerplate transaction test files * docs: add TODOs to update APDU and transaction documentation * style: improve markdown table formatting Temporarily disables outdated test files and marks documentation for updates to match the current application implementation. Part of the transition away from the legacy BOLOK chain example.
* chore: disable unused CMake configuration for unit tests * chore: comment out test executables and library definitions * chore: remove obsolete test linking configuration Comments out boilerplate unit test configuration as part of the transition away from CMake-based testing.
- Add constants for legacy path indices and governance subtree value - Implement dynamic title generation for public key display based on: - Whether the key is signed - Whether it's a governance key - The governance key level (Root, Level 1, Level 2) - Add validation for path types and return SW_INVALID_PATH on invalid paths - Generate new golden snapshots This change improves UX by providing clearer context about the type of public key being displayed to users.
|
The code for this functionality works properly. The only feature missing is governance path support for the new derivation path, more specifically some data about:
|
|
|
||
| #include <stdbool.h> // bool | ||
| #include <string.h> // memset | ||
| // #ifdef HAVE_NBGL |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // #include <stdbool.h> // bool | ||
| // #include <string.h> // memset |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // #include "os.h" | ||
| // #include "glyphs.h" | ||
| // #include "nbgl_use_case.h" | ||
| // #include "io.h" | ||
| // #include "bip32.h" | ||
| // #include "format.h" |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // #include "display.h" | ||
| // #include "constants.h" | ||
| // #include "../globals.h" | ||
| // #include "../sw.h" | ||
| // #include "../address.h" | ||
| // #include "action/validate.h" | ||
| // #include "../transaction/types.h" | ||
| // #include "../menu.h" |
Check notice
Code scanning / CodeQL
Commented-out code Note
| nbgl_useCaseReviewStatus(STATUS_TYPE_ADDRESS_REJECTED, ui_menu_main); | ||
| } | ||
| } | ||
| // static char g_address[43]; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // static void review_choice(bool confirm) { | ||
| // // Answer, display a status page and go back to main | ||
| // validate_pubkey(confirm); | ||
| // if (confirm) { | ||
| // nbgl_useCaseReviewStatus(STATUS_TYPE_ADDRESS_VERIFIED, ui_menu_main); | ||
| // } else { | ||
| // nbgl_useCaseReviewStatus(STATUS_TYPE_ADDRESS_REJECTED, ui_menu_main); | ||
| // } | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // int ui_display_address() { | ||
| // if (G_context.req_type != CONFIRM_ADDRESS || G_context.state != STATE_NONE) { | ||
| // G_context.state = STATE_NONE; | ||
| // return io_send_sw(SW_BAD_STATE); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // memset(g_address, 0, sizeof(g_address)); | ||
| // uint8_t address[ADDRESS_LEN] = {0}; | ||
| // if (!address_from_pubkey(G_context.pk_info.raw_public_key, address, sizeof(address))) { | ||
| // return io_send_sw(SW_DISPLAY_ADDRESS_FAIL); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // if (format_hex(address, sizeof(address), g_address, sizeof(g_address)) == -1) { | ||
| // return io_send_sw(SW_DISPLAY_ADDRESS_FAIL); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // return 0; | ||
| // } | ||
|
|
||
| // #endif |
Check notice
Code scanning / CodeQL
Commented-out code Note
* Remove governance title display logic for new derivation path * Delete unused NEW_PATH constants * Add tests for new derivation path public key retrieval * Clean up path type checks in derivation_path_type function * Generate associated golden snapshots
keiff3r
deleted the
feat/LDG-508--nano-app-implement-getpublickey-method
branch
No description provided.