Test/LDG-517--nano-app-implement-transfertopublic-test #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiff3r
commented
Dec 10, 2024
keiff3r
commented
- Add test P1 enum values for transfer to public testing:
- P1_INITIAL_TRANSFER_TO_PUBLIC
- P1_REMAINING_AMOUNT_TRANSFER_TO_PUBLIC
- P1_PROOF_TRANSFER_TO_PUBLIC
- Implement sign_transfer_to_public test method in BoilerplateCommandSender
- Add test infrastructure for multi-part data verification:
- Test path and header data transmission
- Test remaining amount and transaction details
- Test proof data chunking for large proofs
- Include debug prints for test response validation
- Add test P1 enum values for transfer to public testing: - P1_INITIAL_TRANSFER_TO_PUBLIC - P1_REMAINING_AMOUNT_TRANSFER_TO_PUBLIC - P1_PROOF_TRANSFER_TO_PUBLIC - Implement sign_transfer_to_public test method in BoilerplateCommandSender - Add test infrastructure for multi-part data verification: - Test path and header data transmission - Test remaining amount and transaction details - Test proof data chunking for large proofs - Include debug prints for test response validation
n4l5u0r
approved these changes
Dec 10, 2024
n4l5u0r
deleted the
test/LDG-517--nano-app-implement-transfertopublic-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.