Feat/LDG-504--nano-app-add-support-for-2-derivation-paths #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiff3r
commented
Nov 15, 2024
keiff3r
commented
- add two derivation paths
- bump version, last version in old Concordium is 4.1.2
- add two derivation paths - bump version, last version in old Concordium is 4.1.2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 3 3
Lines 53 53
=======================================
Hits 44 44
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- The last version on Concordium's repo is 4.1.2
- change expected version in two tests - generate golden snapshots
- chenge derivation paths in sign and pubkey tests - generate golden snapshots accordingly
n4l5u0r
requested changes
Nov 15, 2024
n4l5u0r
approved these changes
Nov 15, 2024
keiff3r
deleted the
feat/LDG-504--nano-app-add-support-for-2-derivation-paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.