Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/LDG-599-enable-flex-stax-compilation #20

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

n4l5u0r
Copy link

@n4l5u0r n4l5u0r commented Dec 4, 2024

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Comment on lines +138 to +140
// void io_seproxyhal_display(const bagl_element_t *element) {
// io_seproxyhal_display_default((bagl_element_t *) element);
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +142 to +147
// unsigned char io_event(__attribute__((unused)) unsigned char channel) {
// // can't have more than one tag in the reply, not supported yet.
// switch (G_io_seproxyhal_spi_buffer[0]) {
// case SEPROXYHAL_TAG_FINGER_EVENT:
// UX_FINGER_EVENT(G_io_seproxyhal_spi_buffer);
// break;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +149 to +151
// case SEPROXYHAL_TAG_BUTTON_PUSH_EVENT:
// UX_BUTTON_PUSH_EVENT(G_io_seproxyhal_spi_buffer);
// break;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +153 to +160
// case SEPROXYHAL_TAG_STATUS_EVENT:
// if (G_io_apdu_media == IO_APDU_MEDIA_USB_HID &&
// !(U4BE(G_io_seproxyhal_spi_buffer, 3) &
// SEPROXYHAL_TAG_STATUS_EVENT_FLAG_USB_POWERED)) {
// THROW(EXCEPTION_IO_RESET);
// }
// UX_DEFAULT_EVENT();
// break;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +162 to +164
// case SEPROXYHAL_TAG_DISPLAY_PROCESSED_EVENT:
// UX_DISPLAYED_EVENT({});
// break;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +180 to +182
// // command has been processed, DO NOT reset the current APDU transport
// return 1;
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +184 to +203
// unsigned short io_exchange_al(unsigned char channel, unsigned short tx_len) {
// switch (channel & ~(IO_FLAGS)) {
// case CHANNEL_KEYBOARD:
// break;
// // multiplexed io exchange over a SPI channel and TLV encapsulated protocol
// case CHANNEL_SPI:
// if (tx_len) {
// io_seproxyhal_spi_send(G_io_apdu_buffer, tx_len);
// if (channel & IO_RESET_AFTER_REPLIED) {
// reset();
// }
// return 0; // nothing received from the master so far (it's a tx transaction)
// } else {
// return io_seproxyhal_spi_recv(G_io_apdu_buffer, sizeof(G_io_apdu_buffer), 0);
// }
// default:
// THROW(INVALID_PARAMETER);
// }
// return 0;
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +205 to +214
// void app_exit(void) {
// BEGIN_TRY_L(exit) {
// TRY_L(exit) {
// os_sched_exit(-1);
// }
// FINALLY_L(exit) {
// }
// }
// END_TRY_L(exit);
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +43 to +44
// instructionContext global;
// accountSender_t global_account_sender;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@@ -7,6 +7,6 @@
void (*handler)(uint8_t, uint8_t *, uint8_t, uint8_t, uint8_t, volatile unsigned int *, bool),
void *global_state);

void app_exit(void);
// void app_exit(void);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
keiff3r
keiff3r previously approved these changes Dec 4, 2024
@n4l5u0r n4l5u0r merged commit fc0b78a into main Dec 4, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants