Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDG-508: Implement getPublicKey method #16

Merged
merged 3 commits into from
Dec 4, 2024
Merged

LDG-508: Implement getPublicKey method #16

merged 3 commits into from
Dec 4, 2024

Conversation

keiff3r
Copy link

@keiff3r keiff3r commented Dec 4, 2024

  • Add support for m/44'/CCD'/ipIndex'/identityIndex'/accountIndex' path format
  • Implement getIdentityAccountDisplayNewPath for new path display format
  • Increase display buffer size to accommodate longer path strings
  • Add HARDENED_OFFSET constant for BIP32 path handling
  • Generate golden snapshots

@keiff3r
test(pubkey): fix the pubkey tests
97814d4 
- edit the expected response to remove the pub_key_len and sig_len
- edit the way some test navigate
@keiff3r
feat(pubkey): support new derivation path format
13c8d74 
- Add support for m/44'/CCD'/ipIndex'/identityIndex'/accountIndex' path format
- Implement getIdentityAccountDisplayNewPath for new path display format
- Increase display buffer size to accommodate longer path strings
- Add HARDENED_OFFSET constant for BIP32 path handling
- Generate golden snapshots
@keiff3r keiff3r requested a review from a team December 4, 2024 13:10
@keiff3r keiff3r merged commit f50fd1c into main Dec 4, 2024
28 of 30 checks passed
@keiff3r keiff3r changed the title LDG-505: Implement verifyAddress method LDG-508: Implement getPublicKey method Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n4l5u0r n4l5u0r n4l5u0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keiff3r @n4l5u0r