Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTML format #56

Merged
merged 3 commits into from
May 30, 2020

Conversation

marciniwanicki
Copy link
Contributor

Describe your changes
Added a basic HTML renderer so the report can be quickly open in a browser.
Needed to refactor Renderer and TextProjectCompareResultRenderer to have more flexibility while rendering elements.
Screen Shot 2020-05-25 at 11 25 46 AM

Testing performed
Added only 2 manual test commands for now so we do not need to pay extra cost for all the permutations.

@marciniwanicki marciniwanicki force-pushed the feature/html-renderer branch from bb789c1 to e736bed Compare May 25, 2020 10:34
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   95.77%   96.02%   +0.24%     
==========================================
  Files          43       43              
  Lines        1467     1558      +91     
==========================================
+ Hits         1405     1496      +91     
  Misses         62       62              
Impacted Files Coverage Δ
Sources/XCDiffCore/ProjectComparator.swift 100.00% <ø> (ø)
...ultRenderer/TextProjectCompareResultRenderer.swift 100.00% <100.00%> (ø)
...Core/ResultRenderer/Renderer/ConsoleRenderer.swift 100.00% <100.00%> (ø)
...iffCore/ResultRenderer/Renderer/HTMLRenderer.swift 100.00% <100.00%> (ø)
...ore/ResultRenderer/Renderer/MarkdownRenderer.swift 100.00% <100.00%> (ø)
...fCore/ResultRenderer/UniversalResultRenderer.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb184a6...444e660. Read the comment docs.

@marciniwanicki marciniwanicki force-pushed the feature/html-renderer branch 2 times, most recently from fb59e8a to ecf8299 Compare May 25, 2020 15:04
kwridan
kwridan previously approved these changes May 26, 2020
Copy link
Contributor

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The reports look great 👍

Some ideas for future enhancements:

  • Listing the paths to the projects in the report? (I guess this isn't exclusive to the html report)

Screen Shot 2020-05-26 at 7 57 22 AM

  • Possibly making the sections expandable / collapsable to ease navigation

@marciniwanicki
Copy link
Contributor Author

I like the suggested enhancements :), added tickets: #58, #57

Signed-off-by: Marcin Iwanicki <[email protected]>
Signed-off-by: Marcin Iwanicki <[email protected]>
@marciniwanicki marciniwanicki merged commit 50c0cb4 into bloomberg:master May 30, 2020
@marciniwanicki marciniwanicki deleted the feature/html-renderer branch May 30, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants