Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat[MQB]: Implement cleanupLog function to clean up CSL log #569

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

emelialei88
Copy link
Collaborator

No description provided.

@emelialei88 emelialei88 requested a review from kaikulimu January 13, 2025 20:52
@emelialei88 emelialei88 force-pushed the csl-clean-up branch 2 times, most recently from 2053315 to 5c29540 Compare January 15, 2025 21:07
@emelialei88 emelialei88 marked this pull request as ready for review January 15, 2025 22:23
@emelialei88 emelialei88 requested a review from a team as a code owner January 15, 2025 22:23
Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Good job overall!

src/groups/mqb/mqbc/mqbc_incoreclusterstateledger.cpp Outdated Show resolved Hide resolved
src/groups/mqb/mqbsl/mqbsl_ledger.cpp Outdated Show resolved Hide resolved
src/groups/mqb/mqbsl/mqbsl_ledger.cpp Outdated Show resolved Hide resolved
src/groups/mqb/mqbc/mqbc_incoreclusterstateledger.cpp Outdated Show resolved Hide resolved
src/groups/mqb/mqbc/mqbc_incoreclusterstateledger.cpp Outdated Show resolved Hide resolved
src/groups/mqb/mqbc/mqbc_incoreclusterstateledger.cpp Outdated Show resolved Hide resolved
src/groups/mqb/mqbc/mqbc_incoreclusterstateledger.cpp Outdated Show resolved Hide resolved
src/integration-tests/test_csl_cleanup.py Show resolved Hide resolved
src/integration-tests/test_csl_cleanup.py Show resolved Hide resolved
The function will be scheduled to execute right away
to close and cleanup the log file

Signed-off-by: Emelia Lei <[email protected]>
Signed-off-by: Emelia Lei <[email protected]>
Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaikulimu kaikulimu merged commit f8088c9 into bloomberg:main Jan 16, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants