Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[MQB] mqbc::ClusterUtil: Validate appIds in CSL #545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix[MQB] mqbc::ClusterUtil: Validate appIds in CSL #545

wants to merge 1 commit into from

Conversation

kaikulimu
Copy link
Collaborator

@kaikulimu kaikulimu commented Dec 11, 2024 •
edited
Loading

  1. ClusterUtil::validateState used to ignore appIds. Now it validates.
  2. if (*info != *referenceInfo) should be sufficient to check for appId mismatches, as it relies on the newly added operator== on ClusterStateQueueInfo.
  3. Upgrade CSL validation failure from a warning to an alarm.

@kaikulimu kaikulimu requested a review from dorjesinpo December 11, 2024 10:01
@kaikulimu kaikulimu requested a review from a team as a code owner December 11, 2024 10:01
@kaikulimu
mqbc::ClusterUtil: Validate appIds in CSL
dd3f6dc 
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
@kaikulimu kaikulimu changed the title mqbc::ClusterUtil: Validate appIds in CSL Fix[MQB] mqbc::ClusterUtil: Validate appIds in CSL Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorjesinpo dorjesinpo Awaiting requested review from dorjesinpo

At least 1 approving review is required to merge this pull request.

Assignees

@dorjesinpo dorjesinpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaikulimu @dorjesinpo