Feat[bmqstoragetool]: PrintManager #529
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Pryakhin <[email protected]>
syuzvinsky
reviewed
Nov 25, 2024
| // class PrintManager | ||
| // ================== | ||
|
|
||
| class PrintManager { |
There was a problem hiding this comment.
I would never call this interface PrintManager because its name is too abstract even for an interface :).
Consider something like MessagePrinter or MessagePrinterStrategy.
| {"print-mode", | ||
| "print mode", | ||
| "can be one of the following: [HUMAN, JSON_PRETTY, JSON_LINE]. " | ||
| "Defailt value is HUMAN", |
There was a problem hiding this comment.
Suggested change
| "Defailt value is HUMAN", | |
| "Default value is HUMAN", |
| @@ -57,6 +57,12 @@ parseArgs(CommandLineArguments& arguments, int argc, const char* argv[]) | |||
| "path to a .bmq_csl file", | |||
| balcl::TypeInfo(&arguments.d_cslFile), | |||
| balcl::OccurrenceInfo::e_OPTIONAL}, | |||
| {"print-mode", | |||
| "print mode", | |||
| "can be one of the following: [HUMAN, JSON_PRETTY, JSON_LINE]. " | |||
There was a problem hiding this comment.
Does the tool support lower-case values for this parameter? If not, it would be handy to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the output of the storagetool more grep-friendly or/and to be able to parse it the following changes have been done:
PrintManagerPrintManagerPrintManagerhave been added:JsonLine(each Record is printed as a single-line json) andJsonPretty(each Record is printed as a multi-line json).Left to do:
SearchResultDecorators