fix PushStream & VirtualStorage ordinal #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dorjesinpo <[email protected]>
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
pniedzielski
approved these changes
Nov 26, 2024
| @@ -86,7 +86,7 @@ class VirtualStorageCatalog { | |||
| typedef bsl::shared_ptr<VirtualStorage> VirtualStorageSp; | |||
|
|
|||
| /// List of available ordinal values for Virtual Storages. | |||
| typedef bsl::list<Ordinal> AvailableOrdinals; | |||
| typedef bsl::set<Ordinal> AvailableOrdinals; | |||
There was a problem hiding this comment.
This seems fine. Ensures that we always get the smallest available ordinal, and we're not going to incur the cost of chasing a few more pointers in the critical path.
| @@ -673,7 +660,15 @@ inline unsigned int PushStream::remove(Element* element) | |||
| // remove from the guid | |||
| element->guid().remove(element, e_GUID); | |||
|
|
|||
| return element->guid().numElements(); | |||
| if (element->app().d_elements.numElements() == 0) { | |||
There was a problem hiding this comment.
Centralizing this bit of logic as here seems right. I've traced through the code paths leading up to this and I think this catches all places we need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bugs related to the Monolithic Storage
PushStream::ElementinRelayQueueEngine::beforeMessageRemoved(this assert)