Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat[Storagetool]: Add searching by record sequence numbers and offsets #508

Merged
merged 27 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ca179b8
Add seqnum and offset input args, add composite sequence number support
alexander-e1off Nov 1, 2024
f36e2f6
Debug binary search for all range types
alexander-e1off Nov 7, 2024
2ed441f
Reemove debug
alexander-e1off Nov 7, 2024
23ca939
Simplify getValue template
alexander-e1off Nov 8, 2024
33d990e
Add search result decorators for seq.number and offset, add UTs
alexander-e1off Nov 8, 2024
1bcf853
Fix hasCache() call
alexander-e1off Nov 11, 2024
25a805a
Fix code style
alexander-e1off Nov 11, 2024
9898b5d
Fix code style
alexander-e1off Nov 11, 2024
d00d17c
Add search for specific sequence numbers and offsets
alexander-e1off Nov 12, 2024
1435ed4
Cleanup
alexander-e1off Nov 12, 2024
f1d28fa
Fix README.md
alexander-e1off Nov 13, 2024
f69ee41
Fix typo in README.md
alexander-e1off Nov 13, 2024
6897db6
Update header caption
alexander-e1off Nov 14, 2024
08e4983
Fix review comments
alexander-e1off Nov 19, 2024
27194b8
Fix code style
alexander-e1off Nov 19, 2024
c8758ad
Reset errorDescr
alexander-e1off Nov 29, 2024
7c234b9
Merge branch 'main' into storagetool-add-seqnum
alexander-e1off Dec 3, 2024
768b164
Fix merge conflicts
alexander-e1off Dec 3, 2024
6ecd167
Fix merge conflicts
alexander-e1off Dec 3, 2024
10b24b5
Fix formatting
alexander-e1off Dec 3, 2024
eab1197
Merge remote-tracking branch 'upstream/main' into storagetool-add-seqnum
alexander-e1off Dec 4, 2024
3c7d12f
Merge remote-tracking branch 'upstream/main' into storagetool-add-seqnum
alexander-e1off Dec 5, 2024
561f4da
Merge remote-tracking branch 'upstream/main' into storagetool-add-seqnum
alexander-e1off Dec 6, 2024
a290ba0
Merge from main, fix conflicts
alexander-e1off Dec 16, 2024
e9cf8dd
Fix assert macro names in compositesequencenumber.t
alexander-e1off Dec 16, 2024
d17230a
Merge remote-tracking branch 'upstream/main' into storagetool-add-seqnum
alexander-e1off Dec 18, 2024
73cb8d0
Fix review comments: typos, doxygen comments
alexander-e1off Dec 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions src/applications/bmqstoragetool/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,16 @@ Usage: bmqstoragetool [--journal-path <journal path>]
[--data-file <data file>]
[--csl-file <csl file>]
[--guid <guid>]*
[--seqnum <seqnum>]*
[--offset <offset>]*
[--queue-name <queue name>]*
[--queue-key <queue key>]*
[--timestamp-gt <timestamp greater than>]
[--timestamp-lt <timestamp less than>]
[--seqnum-gt <composit sequence number greater than>]
[--seqnum-lt <composit sequence number less than>]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[--seqnum-gt <composit sequence number greater than>]
[--seqnum-lt <composit sequence number less than>]
[--seqnum-gt <composite sequence number greater than>]
[--seqnum-lt <composite sequence number less than>]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

[--offset-gt <offset greater than>]
[--offset-lt <offset less than>]
[--outstanding]
[--confirmed]
[--partially-confirmed]
Expand All @@ -42,6 +48,10 @@ Where:
path to a .bmq_csl file
--guid <guid>
message guid
--seqnum <seqnum>
message composite sequence number
--offset <offset>
message offset
--queue-name <queue name>
message queue name
--queue-key <queue key>
Expand All @@ -50,6 +60,14 @@ Where:
lower timestamp bound
--timestamp-lt <timestamp less than>
higher timestamp bound
--seqnum-gt <composit sequence number greater than>
lower composit sequence number bound, defined in form <leaseId-sequenceNumber>, e.g. 123-456
--seqnum-lt <composit sequence number less than>
higher composit sequence number bound, defined in form <leaseId-sequenceNumber>, e.g. 123-456
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--seqnum-gt <composit sequence number greater than>
lower composit sequence number bound, defined in form <leaseId-sequenceNumber>, e.g. 123-456
--seqnum-lt <composit sequence number less than>
higher composit sequence number bound, defined in form <leaseId-sequenceNumber>, e.g. 123-456
--seqnum-gt <composite sequence number greater than>
lower composite sequence number bound, defined in form <leaseId-sequenceNumber>, e.g. 123-456
--seqnum-lt <composite sequence number less than>
higher composite sequence number bound, defined in form <leaseId-sequenceNumber>, e.g. 123-456

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

--offset-gt <offset greater than>
lower offset bound
--offset-lt <offset less than>
higher offset bound
--outstanding
show only outstanding (not deleted) messages
--confirmed
Expand Down Expand Up @@ -122,6 +140,22 @@ bmqstoragetool --journal-file=<path> --guid=<guid_1> --guid=<guid_N>
```
NOTE: no other filters are allowed with this one

Filter messages with corresponding composite sequence numbers (defined in form <primaryLeaseId-sequenceNumber>)
---------------------------------------------------------------------------------------------------------------
Example:
```bash
bmqstoragetool --journal-file=<path> --seqnum=<leaseId-sequenceNumber_1> --seqnum=<leaseId-sequenceNumber_N>
```
NOTE: no other filters are allowed with this one
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to want to look at journal records with a particular primary lease ID that happened after a particular timestamp, no?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See earlier comment, let's make this change later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the first step we agreed to make these filters mutual exclusive, and then change behaviour depending on user feedback. Agree to make this change later.


Filter messages with corresponding record offsets
-------------------------------------------------
Example:
```bash
bmqstoragetool --journal-file=<path> --offset=<offset_1> --offset=<offset_N>
```
NOTE: no other filters are allowed with this one

Filter messages within time range
---------------------------------
Example:
Expand All @@ -131,6 +165,24 @@ bmqstoragetool --journal-file=<path> --timestamp-gt=<stamp>
bmqstoragetool --journal-file=<path> --timestamp-lt=<stamp1> --timestamp-gt=<stamp2>
```

Filter messages within composite sequence numbers (primaryLeaseId, sequenceNumber) range
----------------------------------------------------------------------------------------
Example:
```bash
bmqstoragetool --journal-file=<path> --seqnum-lt=<leaseId-sequenceNumber>
bmqstoragetool --journal-file=<path> --seqnum-gt=<leaseId-sequenceNumber>
bmqstoragetool --journal-file=<path> --seqnum-lt=<leaseId1-sequenceNumber1> --seqnum-gt=<leaseId2-sequenceNumber2>
```

Filter messages within record offsets range
-------------------------------------------
Example:
```bash
bmqstoragetool --journal-file=<path> --offset-lt=<offset>
bmqstoragetool --journal-file=<path> --offset-gt=<offset>
bmqstoragetool --journal-file=<path> --offset-lt=<offset1> --offset-gt=<offset2>
```

Filter messages by queue key
----------------------------
Example:
Expand Down
42 changes: 38 additions & 4 deletions src/applications/bmqstoragetool/bmqstoragetool.m.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@
using namespace BloombergLP;
using namespace m_bmqstoragetool;

static bool
parseArgs(CommandLineArguments& arguments, int argc, const char* argv[])
static bool parseArgs(CommandLineArguments& arguments,
int argc,
const char* argv[],
bslma::Allocator* allocator)
{
bool showHelp = false;

Expand Down Expand Up @@ -62,6 +64,16 @@ parseArgs(CommandLineArguments& arguments, int argc, const char* argv[])
"message guid",
balcl::TypeInfo(&arguments.d_guid),
balcl::OccurrenceInfo::e_OPTIONAL},
{"seqnum",
"seqnum",
"message composite sequence number",
balcl::TypeInfo(&arguments.d_seqNum),
balcl::OccurrenceInfo::e_OPTIONAL},
{"offset",
"offset",
"message offset",
balcl::TypeInfo(&arguments.d_offset),
balcl::OccurrenceInfo::e_OPTIONAL},
{"queue-name",
"queue name",
"message queue name",
Expand All @@ -82,6 +94,28 @@ parseArgs(CommandLineArguments& arguments, int argc, const char* argv[])
"higher timestamp bound",
balcl::TypeInfo(&arguments.d_timestampLt),
balcl::OccurrenceInfo::e_OPTIONAL},
{"seqnum-gt",
"message composite sequence number greater than",
"lower record sequence number bound, defined in form "
"<leaseId-sequenceNumber>",
balcl::TypeInfo(&arguments.d_seqNumGt),
balcl::OccurrenceInfo::e_OPTIONAL},
{"seqnum-lt",
"message composite sequence number less than",
"higher sequence number bound, defined in form "
"<leaseId-sequenceNumber>",
balcl::TypeInfo(&arguments.d_seqNumLt),
balcl::OccurrenceInfo::e_OPTIONAL},
{"offset-gt",
"message offset greater than",
"lower record offset bound",
balcl::TypeInfo(&arguments.d_offsetGt),
balcl::OccurrenceInfo::e_OPTIONAL},
{"offset-lt",
"message offset less than",
"higher record offset bound",
balcl::TypeInfo(&arguments.d_offsetLt),
balcl::OccurrenceInfo::e_OPTIONAL},
{"outstanding",
"only outstanding",
"show only outstanding (not deleted) messages",
Expand Down Expand Up @@ -130,7 +164,7 @@ parseArgs(CommandLineArguments& arguments, int argc, const char* argv[])
}

bsl::string error;
if (!arguments.validate(&error)) {
if (!arguments.validate(&error, allocator)) {
bsl::cerr << "Arguments validation failed:\n" << error;
return false; // RETURN
}
Expand All @@ -157,7 +191,7 @@ int main(int argc, const char* argv[])

// Arguments parsing
CommandLineArguments arguments(allocator);
if (!parseArgs(arguments, argc, argv)) {
if (!parseArgs(arguments, argc, argv, allocator)) {
return rc_ARGUMENTS_PARSING_FAILED; // RETURN
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
// Copyright 2014-2023 Bloomberg Finance L.P.
// SPDX-License-Identifier: Apache-2.0
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// bmqstoragetool
#include <m_bmqstoragetool_compositesequencenumber.h>

// BDE
#include <bdlb_print.h>
#include <bsl_stdexcept.h>

namespace BloombergLP {
namespace m_bmqstoragetool {

// =============================
// class CompositeSequenceNumber
// =============================

CompositeSequenceNumber::CompositeSequenceNumber()
: d_leaseId(0)
, d_seqNumber(0)
, d_isSet(false)
{
// NOTHING
}

CompositeSequenceNumber::CompositeSequenceNumber(
const unsigned int leaseId,
const bsls::Types::Uint64 sequenceNumber)
: d_leaseId(leaseId)
, d_seqNumber(sequenceNumber)
{
BSLS_ASSERT(d_leaseId > 0 && d_seqNumber > 0);
d_isSet = d_leaseId > 0 && d_seqNumber > 0;
}

CompositeSequenceNumber&
CompositeSequenceNumber::fromString(bsl::ostream& errorDescription,
const bsl::string& seqNumString)
{
d_isSet = false;

if (seqNumString.empty()) {
errorDescription << "Invalid input: empty string.";
return *this; // RETURN
}

// Find the position of the separator
const size_t separatorPos = seqNumString.find('-');
if (separatorPos == bsl::string::npos) {
errorDescription << "Invalid format: no '-' separator found.";
return *this; // RETURN
}

// Extract parts
const bsl::string firstPart = seqNumString.substr(0, separatorPos);
const bsl::string secondPart = seqNumString.substr(separatorPos + 1);

// Convert parts to numbers
try {
size_t posFirst, posSecond;

unsigned long uLong = bsl::stoul(firstPart, &posFirst);
d_seqNumber = bsl::stoul(secondPart, &posSecond);

if (posFirst != firstPart.size() || posSecond != secondPart.size()) {
throw bsl::invalid_argument(""); // THROW
}

d_leaseId = static_cast<unsigned int>(uLong);
if (uLong != d_leaseId) {
throw bsl::out_of_range(""); // THROW
}

if (d_leaseId == 0 || d_seqNumber == 0) {
errorDescription << "Invalid input: zero values encountered.";
return *this; // RETURN
}

d_isSet = true;
}
catch (const bsl::invalid_argument& e) {
errorDescription << "Invalid input: non-numeric values encountered.";
}
catch (const bsl::out_of_range& e) {
errorDescription << "Invalid input: number out of range.";
}

return *this;
}

bsl::ostream& CompositeSequenceNumber::print(bsl::ostream& stream,
int level,
int spacesPerLevel) const
{
if (stream.bad()) {
return stream; // RETURN
}

bdlb::Print::indent(stream, level, spacesPerLevel);

if (isSet()) {
stream << "leaseId: " << leaseId()
<< ", sequenceNumber: " << sequenceNumber();
}
else {
stream << "** UNSET **";
}

if (spacesPerLevel >= 0) {
stream << '\n';
}

return stream;
}

} // close package namespace
} // close enterprise namespace
Loading
Loading