Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf[MQB]: remove unnecessary shared_ptr copy #480

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Perf[MQB]: remove unnecessary shared_ptr copy #480

merged 1 commit into from
Oct 28, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Oct 26, 2024 •
edited
Loading

Before:
Screenshot 2024-10-26 at 03 35 56

After (PriorityGroup::evaluate was inlined):
Screenshot 2024-10-26 at 06 33 23

@678098 678098 requested a review from a team as a code owner October 26, 2024 05:38
bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Oct 26, 2024
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 335 of commit a7eca1c has completed with FAILURE

@678098 678098 requested a review from dorjesinpo October 28, 2024 10:14
@678098 678098 merged commit c140945 into bloomberg:main Oct 28, 2024
31 checks passed
@678098 678098 deleted the 241026_fix_evaluate_sp branch October 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmq-oss-ci bmq-oss-ci[bot] bmq-oss-ci[bot] left review comments

@dorjesinpo dorjesinpo dorjesinpo approved these changes

Assignees

@dorjesinpo dorjesinpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @dorjesinpo