Perf[MQB]: do not build temporary functors for every routed message #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeny Malygin <[email protected]>
678098
force-pushed
the
241024_perf_AppContext_visitor
branch
from
66be800 to
c6d38ea
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
678098
commented
Oct 27, 2024
| allocator, | ||
| &QueueEngineUtil_AppsDeliveryContext::visitBroadcast, | ||
| this, | ||
| bdlf::PlaceHolders::_1)) |
There was a problem hiding this comment.
The alternative to this is to make Visitor functor and inherit from it locally.
Like here:
#481
There was a problem hiding this comment.
To implement new DeliveryContext interface...
There was a problem hiding this comment.
Let's discuss it later then
dorjesinpo
approved these changes
Oct 28, 2024
| allocator, | ||
| &QueueEngineUtil_AppsDeliveryContext::visitBroadcast, | ||
| this, | ||
| bdlf::PlaceHolders::_1)) |
There was a problem hiding this comment.
To implement new DeliveryContext interface...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should save 1% out of 36.4% of the queue dispatcher thread and reduce the total number of allocations.
Before:
After:
