Misc[docker]: Adding dependency of bmqbrkr to bmqtool in docker-compose.yaml single-node example #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #476 *
Describe your changes
Great project!
Testing the examples listed on the official Getting Started page on a M1 Macbook Pro (darwin/arm64) and I notice the build and example instructions don't work.
Think this is due to two reasons:
-DBDE_BUILD_SAFE=on
works.bmqtool
in the doc link above doesn't work -start
fails to connect, because thebmqbrkr
is not started. This is probably becausebmqtool
doesn't depend onbmqbrkr
service container - which it should.This PR fixes the 2nd issue by adding a dependency on
bmqbrkr
inbmqtool
viadepends_on
. I am still going through how broker health checks work - it should beservice_healthy
instead, but I couldn't find an easy way to do this in thebmqtool
CLI help. So usingservice_started
instead - to only startbmqtool
container oncePartially addresses #476
Testing performed
Follow all the steps listed here with workaround suggested in 1 and the
depends_on
changes in this PR - everything from building and testing the queue should work as intended.Additional context
N/A. I might make more PRs - this project looks interesting.