Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly call gc when not idle #283

Merged
merged 1 commit into from
May 13, 2024
Merged

explicitly call gc when not idle #283

merged 1 commit into from
May 13, 2024

Conversation

dorjesinpo
Copy link
Collaborator

Busy broker may not have enough idleness/time to gcHistory
Forcibly schedule it if needed. It will intersperse with incoming work

@dorjesinpo dorjesinpo requested a review from a team as a code owner May 10, 2024 20:39
@dorjesinpo dorjesinpo added the bug Something isn't working label May 10, 2024
@dorjesinpo dorjesinpo requested a review from pniedzielski May 10, 2024 20:40
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase GC message count comes in a different PR right?

@dorjesinpo
Copy link
Collaborator Author

Increase GC message count comes in a different PR right?

There should be no need. Now, the gc reschedules itself when the count is not enough. Before, it was waiting for idleness,

@dorjesinpo dorjesinpo merged commit 9369e10 into main May 13, 2024
17 checks passed
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants