Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set correct partitionId on storage summary #280

Merged
merged 1 commit into from
May 10, 2024
Merged

Fix: set correct partitionId on storage summary #280

merged 1 commit into from
May 10, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented May 9, 2024 •
edited
Loading

Problem: when storage is not open, we print default partitionId [0]

   Storage Summary:
    ----------------
        Storage location: ........................


    PartitionId [0]: NOT OPEN.
    PartitionId [0]: NOT OPEN.
    PartitionId [0]: NOT OPEN.
    PartitionId [0]: NOT OPEN.
    PartitionId [0]: NOT OPEN.
    PartitionId [0]: NOT OPEN.
    PartitionId [0]: NOT OPEN.
    PartitionId [0]: NOT OPEN.RECOVERY

Note that FileStore is always constructed with valid existing config object, even if this FileStore is not opened yet:

blazingmq/src/groups/mqb/mqbs/mqbs_filestore.cpp

Line 5108 in 2693766

FileStore::FileStore(const DataStoreConfig& config,

@678098 678098 requested a review from a team as a code owner May 9, 2024 14:54
@678098 678098 requested a review from kaikulimu May 10, 2024 13:34
kaikulimu
kaikulimu approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@678098 678098 merged commit c23cfa9 into main May 10, 2024
15 checks passed
@678098 678098 deleted the 678098-patch-2 branch May 10, 2024 17:19
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Fix: set correct partitionId on storage summary (bloomberg#280)
f857157 
Signed-off-by: Evgeny Malygin <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Fix: set correct partitionId on storage summary (bloomberg#280)
d271594 
Signed-off-by: Evgeny Malygin <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Fix: set correct partitionId on storage summary (bloomberg#280)
a9bfcb4 
Signed-off-by: Evgeny Malygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikulimu kaikulimu kaikulimu approved these changes

Assignees

@kaikulimu kaikulimu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @kaikulimu