C++20 fixes #130
Merged
C++20 fixes #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallfox
approved these changes
Oct 18, 2023
|
Hi @ccotter, Thanks for your contribution! We require all our contributors to sign off on their commits acknowledging that they indeed have the right to convey their contribution to us under our license. Could you |
std::not1 is removed from C++20. Since this code is expected to be built on C++03 as well as C++11 and newer, this patch embeds an adhoc version of 'not1' instead of, e.g., using a lambda expression. Signed-off-by: Chris Cotter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
[A clear and concise description of the changes you have made.
](std::not1 is removed from C++20. Since this code is expected to be built on C++03 as well as C++11 and newer, this patch embeds an adhoc version of 'not1' instead of, e.g., using a lambda expression.)
Testing performed
I ran the internal DPKG build for bmqbrkr.