Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds governance configuration #152

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Adds governance configuration #152

merged 5 commits into from
Nov 22, 2023

Conversation

jeffmaher-bloom
Copy link
Contributor

Pull Request Background

This implements the configuration to control who can review and approve changes to the Handbook. This is based on the governance proposal doc.

Anyone reviewing can look at the .github/CODEOWNERS file to see which files are assigned to which group.

GitHub Issue

What Changed

Outside the pull request, a few non-code changes happened:

  • Added teams that are the groups of approvers based on topic
  • Turn on the repository setting that assigns reviewers based on the .github/CODEOWNERS setting
  • Turn on the repository setting that requires reviews/approvals from the assigned groups in .github/CODEOWNERS

In terms of code changes, added the .github/CODEOWNERS file.

Other Notes

Unfortunately, this can't really be tested until it's merged. This is because the configuration doesn't fully take effect until it's in the main branch. This means that there will likely be some bugs that will need to be followed up with subsequent pull requests.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for bloom-handbook ready!

Name Link
🔨 Latest commit 0def100
🔍 Latest deploy log https://app.netlify.com/sites/bloom-handbook/deploys/655e3f3d8c08e700089d728f
😎 Deploy Preview https://deploy-preview-152--bloom-handbook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeffmaher-bloom
Copy link
Contributor Author

@coreycaitlin and @dottiebobottie : Let me know if you want to review together, but feel free to review independently if the configuration file reads clearly to you.

Copy link
Contributor

@coreycaitlin coreycaitlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge so we can see how it works!

@jeffmaher-bloom jeffmaher-bloom merged commit dbe9bda into main Nov 22, 2023
4 checks passed
@jeffmaher-bloom jeffmaher-bloom deleted the governance branch November 22, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement governance plan in code and content
2 participants