-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program: add switchboard on demand oracle support #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependency
Dependency updates
program
On-chain program changes
labels
Jun 25, 2024
farnyser
force-pushed
the
serge/sb_on_demand
branch
from
June 25, 2024 12:08
8f8497e
to
99d493a
Compare
mschneider
reviewed
Jun 25, 2024
require_gte!(price, 0); | ||
OracleState { | ||
price, | ||
last_update_slot: last_update_slot, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style nit: can be simplified
@@ -388,6 +400,7 @@ fn oracle_state_unchecked_inner<T: KeyedAccountReader>( | |||
} | |||
} | |||
OracleType::SwitchboardV1 => { | |||
// return Err(MangoError::ObsoleteOracle.into()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this comment
microwavedcola1
approved these changes
Jun 25, 2024
farnyser
added a commit
that referenced
this pull request
Jun 25, 2024
--------- Co-authored-by: Mitch Gildenberg <[email protected]> (cherry picked from commit ed28450)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.