Add an Orca oracle type #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckamm
reviewed
Dec 13, 2023
| let whirlpool = Whirlpool::try_deserialize(&mut &data[..]).unwrap(); | ||
| require!( | ||
| whirlpool.token_mint_a == usdc_mint_mainnet::ID | ||
| || whirlpool.token_mint_b == usdc_mint_mainnet::ID, |
There was a problem hiding this comment.
ah, you flip implicitly based on what USDC is, smart!
|
I'd like to see an integration test that uses an orca oracle. It's reasonably easy to do now that ProgramTestContext has set_account(). (our solana.rs has a new set_account() for anchor-style accounts, added fairly recently in dev - but ProgramTestContext::set_account() can also set some bytes you read from a file to a chosen address) |
ckamm
reviewed
Dec 14, 2023
ckamm
reviewed
Dec 14, 2023
ckamm
reviewed
Dec 14, 2023
ckamm
reviewed
Dec 14, 2023
Lou-Kamades
force-pushed
the
lou/orca-oracle
branch
7 times, most recently
from
dcd2abb to
38143d0
Compare
ckamm
reviewed
Dec 21, 2023
programs/mango-v4/src/instructions/perp_liq_negative_pnl_or_bankruptcy.rs
Show resolved
Hide resolved
| account.set_data(data); | ||
| let mut program_test_context = solana.context.borrow_mut(); | ||
| program_test_context.set_account(&Pubkey::from_str(fixture.0).unwrap(), &account); | ||
| } |
Lou-Kamades
force-pushed
the
lou/orca-oracle
branch
from
9a58fa1 to
0e82de1
Compare
ckamm
reviewed
Dec 27, 2023
ckamm
reviewed
Dec 27, 2023
ckamm
reviewed
Dec 27, 2023
ckamm
reviewed
Dec 27, 2023
ckamm
reviewed
Dec 27, 2023
| @@ -344,7 +344,7 @@ async fn test_health_compute_tokens_fallback_oracles() -> Result<(), TransportEr | |||
| #[tokio::test] | |||
| async fn test_health_compute_serum() -> Result<(), TransportError> { | |||
| let mut test_builder = TestContextBuilder::new(); | |||
| test_builder.test().set_compute_max_units(130_500); | |||
| test_builder.test().set_compute_max_units(135_000); | |||
There was a problem hiding this comment.
huh, how did this patch raise the CU cost this much?
|
if the index thing is a real issue, then this code is undertested (and has been before); would much appreciate adding a test that would at least detect essential issues like this one (Resolved: was not a real issue) |
ckamm
reviewed
Jan 3, 2024
Lou-Kamades
force-pushed
the
lou/orca-oracle
branch
from
3fa1535 to
09484b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.