Bank: allow maint weights to change over time #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ckamm
commented
Nov 14, 2023
ckamm
commented
- token_edit can set it up to gradually scale to new target values
- security admin can abort an ongoing change via token_edit
- all health computations are now time dependent and get the weight based on it
- when the change is done, the keeper "cleans up" and moves the new values into the default fields
- token_edit can set it up to gradually scale to new target values - security admin can abort an ongoing change via token_edit - all health computations are now time dependent and get the weight based on it - when the change is done, the keeper "cleans up" and moves the new values into the default fields
microwavedcola1
approved these changes
Nov 14, 2023
| ) | ||
| } else { | ||
| let scale = I80F48::from(now_ts - self.maint_weight_shift_start) | ||
| * self.maint_weight_shift_duration_inv; |
There was a problem hiding this comment.
any arguments for non-linear movement?
microwavedcola1
approved these changes
Nov 14, 2023
ckamm
force-pushed
the
ckamm/maint-weight-shift
branch
from
4385230 to
8c27698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.