Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph integration #2284

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Graph integration #2284

merged 1 commit into from
Oct 22, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented Oct 4, 2024

Description and Related Issue(s)

resolves #2245

Proposed Changes

added NEXT_PUBLIC_MARKETPLACE_GRAPH_LINKS_URL variable for an external url to the graph links config

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@isstuev isstuev marked this pull request as ready for review October 14, 2024 13:14
@isstuev isstuev requested review from maxaleks and tom2drum October 14, 2024 13:14
@github-actions github-actions bot added the enhancement New feature or request label Oct 14, 2024
maxaleks
maxaleks reviewed Oct 16, 2024
View reviewed changes
deploy/tools/envs-validator/schema.ts Outdated Show resolved Hide resolved
lib/hooks/useGraphLinks.tsx Outdated Show resolved Hide resolved
@tom2drum tom2drum added the ENVs label Oct 16, 2024
@isstuev isstuev requested a review from maxaleks October 18, 2024 08:46
tom2drum
tom2drum approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@tom2drum tom2drum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we extend some of the existing test cases to demonstrate the new integration?

@isstuev
Copy link
Collaborator Author

isstuev commented Oct 22, 2024

Should we extend some of the existing test cases to demonstrate the new integration?

I'm not sure since it's a temporary/experimental one

@isstuev isstuev merged commit 4d14641 into main Oct 22, 2024
12 checks passed
@isstuev isstuev deleted the fe-2245 branch October 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

@maxaleks maxaleks Awaiting requested review from maxaleks

Assignees
No one assigned
Labels
enhancement New feature or request ENVs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph integration
3 participants
@isstuev @maxaleks @tom2drum