Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapp ratings #2089

Merged
merged 65 commits into from
Jul 23, 2024
Merged

Dapp ratings #2089

merged 65 commits into from
Jul 23, 2024

Conversation

maxaleks
Copy link
Contributor

@maxaleks maxaleks commented Jul 9, 2024 •
edited
Loading

Description and Related Issue(s)

Resolves #2015 and #1972

New env vars:

  • NEXT_PUBLIC_MARKETPLACE_RATING_AIRTABLE_API_KEY
  • NEXT_PUBLIC_MARKETPLACE_RATING_AIRTABLE_BASE_ID

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

tom2drum
tom2drum requested changes Jul 16, 2024
View reviewed changes
nextjs/csp/policies/app.ts Outdated Show resolved Hide resolved
ui/marketplace/MarketplaceAppCard.tsx Outdated Show resolved Hide resolved
ui/marketplace/Banner/FeaturedApp.tsx Outdated Show resolved Hide resolved
ui/marketplace/MarketplaceAppModal.tsx Outdated Show resolved Hide resolved
ui/marketplace/MarketplaceAppModal.tsx Outdated Show resolved Hide resolved
ui/marketplace/Rating/useRatings.tsx Outdated Show resolved Hide resolved
ui/marketplace/Rating/useRatings.tsx Outdated Show resolved Hide resolved
...ared/entities/address/__screenshots__/AddressEntity.pw.tsx_default_contract-unverified-1.png Outdated Show resolved Hide resolved
...ets/navigation/vertical/__screenshots__/NavigationDesktop.pw.tsx_default_with-tooltips-1.png Outdated Show resolved Hide resolved
ui/marketplace/Rating/useRatings.tsx Outdated Show resolved Hide resolved
@maxaleks maxaleks requested a review from tom2drum July 17, 2024 21:18
tom2drum
tom2drum approved these changes Jul 18, 2024
View reviewed changes
ui/shared/forms/FileSnippet.tsx Show resolved Hide resolved
@maxaleks maxaleks merged commit 035256a into main Jul 23, 2024
7 checks passed
@maxaleks maxaleks deleted the dapp-rating branch July 23, 2024 12:50
@maxaleks maxaleks linked an issue Aug 5, 2024 that may be closed by this pull request
Add lazy loading of dapps on DAppscout #1972
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

@isstuev isstuev Awaiting requested review from isstuev

Assignees
No one assigned
Labels
ENVs feature New substantial feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Dappscout rating Add lazy loading of dapps on DAppscout
2 participants
@maxaleks @tom2drum