Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback to 'image_url' if 'animation_url' is invalid for NFT instance #1670

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Add fallback to 'image_url' if 'animation_url' is invalid for NFT instance #1670

merged 3 commits into from
Mar 7, 2024

Conversation

tom2drum
Copy link
Collaborator

@tom2drum tom2drum commented Mar 5, 2024

Description and Related Issue(s)

Resolves #1669

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@tom2drum tom2drum requested a review from isstuev March 5, 2024 12:48
@tom2drum tom2drum merged commit 8e6a099 into main Mar 7, 2024
18 of 19 checks passed
@tom2drum tom2drum deleted the hotfix/nft-image branch March 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isstuev isstuev isstuev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fallback to 'image_url' if 'animation_url' is invalid for NFT instance
3 participants
@tom2drum @isstuev @ArminaAiren