Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name service integration #1460

Merged
merged 30 commits into from
Jan 17, 2024
Merged

Name service integration #1460

merged 30 commits into from
Jan 17, 2024

Conversation

tom2drum
Copy link
Collaborator

@tom2drum tom2drum commented Dec 25, 2023 •
edited
Loading

Description and Related Issue(s)

Resolves #1376

Proposed Changes

I have added the NEXT_PUBLIC_NAME_SERVICE_API_HOST variable to enable the ENS feature.

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@tom2drum tom2drum added the skip checks For Pull Requests where the "Checks" workflow should not be run label Dec 25, 2023
@tom2drum tom2drum changed the title Nave service integration Name service integration Dec 25, 2023
@tom2drum tom2drum added the QA Pull requests requiring manual QA. label Dec 26, 2023
@tom2drum tom2drum removed the skip checks For Pull Requests where the "Checks" workflow should not be run label Dec 28, 2023
@tom2drum tom2drum marked this pull request as ready for review December 28, 2023 15:09
@tom2drum tom2drum requested a review from isstuev December 28, 2023 15:10
@isstuev
Copy link
Collaborator

isstuev commented Jan 8, 2024

I would set higher line height here
image

@isstuev
Copy link
Collaborator

isstuev commented Jan 8, 2024

do we need to show "domains" button on the address page if there is only one domain? if yes, it should be "1 domain", not "domains"
image

@tom2drum tom2drum merged commit 61f676b into main Jan 17, 2024
9 checks passed
@tom2drum tom2drum deleted the tom2drum/issue-1376 branch January 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isstuev isstuev Awaiting requested review from isstuev

Assignees
No one assigned
Labels
QA Pull requests requiring manual QA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naming systems integration (ENS)
2 participants
@tom2drum @isstuev