Noves integration

[juanlenoves]

Here's our code for integrating Noves data with Blockscout.

Our goal is to significantly improve user experience by displaying Noves-translated transaction types and human-readable descriptions, on both the account and transaction detail pages.

We've been working on this in close collaboration with the Blockscout team, and are very excited for what's to come :)

Happy to make any revisions as needed.

[tom2drum]

Please note that our designer has updated the mock-ups for the assets flow table.

We believe there is no need to truncate the value string. The column width should be sufficient to display the entire value. If required, we can truncate the token symbol instead. Therefore, we can utilize a regular tooltip for the TokenEntity component here instead of creating a custom one.

[juanlenoves]

I believe all items from previous submissions have been addressed with the latest push. Please correct me if I'm wrong, but we should be very close or basically done here (and I hope that's a true statement 🙏)

[tom2drum]

Great job, Juan! 🙌

Most of my comments have been addressed. However, there are still a few things that I believe should be changed:

• The structure of the useDescribeTxs hook
• The changes in the TxType component

For more details, please refer to the unresolved conversations above.

In addition, since we are nearing the final implementation of the feature, I suggest that you write some visual tests for all the views and components you have added, where appropriate. This will give us greater confidence in future releases that the layout and functionality of these components are not affected by new changes.

After resolving all the questions, I will deploy a demo and share it with our product manager and designer for review. Meanwhile, you can focus on writing test suites.

[juanlenoves]

Hi Tom,

Our latest commit should address all pending comments, and we believe this should be ready to go.

I made a final adjustment and assumed that for describe_txs, the API endpoint that you expose via the custom proxy will be called "transaction-descriptions" and not just "transactions". This is much more accurate and descriptive of what that endpoint returns (just the minimalistic output with the descriptions, not the full transactions).

[tom2drum]

I made a final adjustment and assumed that for describe_txs, the API endpoint that you expose via the custom proxy will be called "transaction-descriptions" and not just "transactions".

Has the underlying endpoint in Noves API been changed? We have already deployed our proxy service. Can we keep using the previous name? If not, we need to wait for the proxy to be redeployed before building a demo.

[tom2drum]

In order to run code checks and tests, could you please merge the main branch into yours and resolve any conflicts?

[tom2drum]

• The issue with space between tx subheading text and icon is not fixed for loading state

Screenshot

[juanlenoves]

• The issue with space between tx subheading text and icon is not fixed for loading state

Screenshot

Should be addressed in latest commits

[tom2drum]

👍 I will re-deploy the demo