watchlist and private tags pagination #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isstuev
force-pushed
the
acc-pagination
branch
2 times, most recently
from
aa6dd35 to
4a30d1e
Compare
tom2drum
approved these changes
Nov 7, 2023
| }); | ||
| } else { | ||
| queryClient.setQueryData([ resourceKey('private_tags_tx') ], (prevData: TransactionTags | undefined) => { | ||
| return prevData?.filter((item: TransactionTag) => item.id !== id); | ||
| queryClient.setQueryData([ resourceKey('private_tags_tx') ], (prevData: TransactionTagsResponse | undefined) => { |
There was a problem hiding this comment.
I think we should use getResourceKey here as well
isstuev
force-pushed
the
acc-pagination
branch
from
4a30d1e to
2c3c62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1264