Hotfix for Noves integration error with undefined addresses (#1803)

Fix error with addresses Co-authored-by: NahuelNoves <[email protected]>
blockscout · Apr 11, 2024 · 3a9c6cb · 3a9c6cb
1 parent dd93c2b
commit 3a9c6cb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/types/api/noves.ts b/types/api/noves.ts
@@ -20,6 +20,7 @@ export interface NovesClassificationData {
     type: string | null;
   };
   message?: string;
+  deployedContractAddress?: string;
 }
 
 export interface Approved {

diff --git a/ui/tx/assetFlows/utils/getAddressValues.ts b/ui/tx/assetFlows/utils/getAddressValues.ts
@@ -57,6 +57,10 @@ function extractAddresses(data: NovesResponseData) {
     addressesSet.add({ hash: data.classificationData.approved.spender });
   }
 
+  if (data.classificationData.deployedContractAddress) {
+    addressesSet.add({ hash: data.classificationData.deployedContractAddress });
+  }
+
   if (data.txTypeVersion === 2) {
     data.classificationData.sent.forEach((transaction) => {
       addressesSet.add({ hash: transaction.from.address, name: transaction.from.name });
@@ -72,5 +76,5 @@ function extractAddresses(data: NovesResponseData) {
   const addresses = Array.from(addressesSet) as Array<{hash: string; name?: string}>; // Convert Set to an array
 
   // Remove empty and null values
-  return addresses.filter(address => address.hash !== null && address.hash !== '');
+  return addresses.filter(address => address.hash !== null && address.hash !== '' && address.hash !== undefined);
 }